feat(vue): add key and meta, and re-export createBeforeEachHandlers
#244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agitated-mahavira-26f8f9 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@galvez I think this is a better approach, see the first commit for the changes to the vue package, and the second commit on how I've overridden the routing creation to enable i18n routing. The routing file is a bit verbose, but I don't think we could shorten it that much to be honest |
This allows the developer to use their own key for the routeMap matching, as well as provide meta data per route. This also re-exports beforeEach handlers, so that they can be overridden in the virtual files.
This example overrides $app/index.js and provides new route creation as well as beforeEach handlers to enable locale prefix and domain routing.
zanmato
force-pushed
the
feature-modular-i18n
branch
from
73ac965 to
e0a449b
Compare
This confuses vite's build import analysis
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
keyandmetato the route context, and re-exports the beforeEach routing handlers from$app/indexto allow the developer to override these methods.Also adds an i18n example (
vue-i18n) that has both locale prefix and domain routing, by overriding the above methods and properties.Checklist
npm run testandnpm run benchmarkand the Code of conduct